This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Added e2e test for automatic issuance and bug fixes. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added the e2e for automatic issuance, which involves creating an IssuanceTemplate.
Description
Some additional changes in this PR
errwas being returned though it was actuallynil.GetResponsereturn the same shape as what is in theoperation.resultof callingSubmitApplication.datacontains only the claims about credentialSubject.How Has This Been Tested?
The e2e test was added.
All other tests still pass.
References
Final pieces of SIP 5.